john
/
McRogueFace
1
0
Fork 0
Code Issues 52 Pull Requests Projects 1 Releases Wiki Activity

chore: changing comments to reflect TODOs conversion to issues

This commit is contained in:
John McCardle 2024-03-12 21:03:39 -04:00
parent 8739da8463
commit 2c3c1449ee
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/UI.h
View File

@ -1509,7 +1509,7 @@ static PyObject* UIGridPointState_to_PyObject(const UIGridPointState& state) {
if (!obj) return PyErr_NoMemory(); if (!obj) return PyErr_NoMemory();
// Assuming PyUIGridPointStateObject structure has a UIGridPointState* member called 'data' // Assuming PyUIGridPointStateObject structure has a UIGridPointState* member called 'data'
//((PyUIGridPointStateObject*)obj)->data = new UIGridPointState(state); // Copy constructor // TODO / BUGFIX - don't use new, get shared_ptr working //((PyUIGridPointStateObject*)obj)->data = new UIGridPointState(state); // Copy constructor // wontimplement / feat - don't use new, get shared_ptr working
return obj; return obj;
} }
@ -1807,7 +1807,6 @@ static PyGetSetDef PyUIGrid_getsetters[] = {
{"size", (getter)PyUIGrid_get_size, (setter)PyUIGrid_set_size, "Size of the grid (width, height)", NULL}, {"size", (getter)PyUIGrid_get_size, (setter)PyUIGrid_set_size, "Size of the grid (width, height)", NULL},
{"center", (getter)PyUIGrid_get_center, (setter)PyUIGrid_set_center, "Grid coordinate at the center of the Grid's view (pan)", NULL}, {"center", (getter)PyUIGrid_get_center, (setter)PyUIGrid_set_center, "Grid coordinate at the center of the Grid's view (pan)", NULL},
// TODO / BUGFIX - everything about Entity collection
{"entities", (getter)PyUIGrid_get_children, NULL, "EntityCollection of entities on this grid", NULL}, {"entities", (getter)PyUIGrid_get_children, NULL, "EntityCollection of entities on this grid", NULL},
{"x", (getter)PyUIGrid_get_float_member, (setter)PyUIGrid_set_float_member, "top-left corner X-coordinate", (void*)0}, {"x", (getter)PyUIGrid_get_float_member, (setter)PyUIGrid_set_float_member, "top-left corner X-coordinate", (void*)0},
@ -2103,12 +2102,7 @@ static int PyUIEntity_init(PyUIEntityObject* self, PyObject* args, PyObject* kwd
return NULL; return NULL;
} }
// release the shared pointer at self->data[index]; // release the shared pointer at correct part of the list
//self->data->erase(self->data->begin() + index);
// (Advance list to position)
//auto l_front = self->data->begin();
//std::advance(l_front, index);
//self->data->erase(std::remove(l_front, std::next(l_front)); // TODO / BUGFIX - ???
self->data->erase(std::next(self->data->begin(), index)); self->data->erase(std::next(self->data->begin(), index));
Py_INCREF(Py_None); Py_INCREF(Py_None);
return Py_None; return Py_None;
@ -2146,7 +2140,7 @@ static int PyUIEntity_init(PyUIEntityObject* self, PyObject* args, PyObject* kwd
return NULL; // Failed to allocate memory for the iterator object return NULL; // Failed to allocate memory for the iterator object
} }
iterObj->data = self->data; // TODO / BUGFIX - mismatch between the Iter Type and Collection Type Data members iterObj->data = self->data;
iterObj->index = 0; iterObj->index = 0;
iterObj->start_size = self->data->size(); iterObj->start_size = self->data->size();