clean up COMP4300 style #44

New Issue

john · 2024-03-09T19:42:16Z

john commented

2024-03-09 19:42:16 +00:00

61 refactor: clean up COMP4300 style and remove "e" / "c" / "s" prefixes on GameEngine / Scene methods

john added the

Tiny Feature

Refactoring & Cleanup

labels 2024-03-09 19:42:16 +00:00

john added this to the All Datatypes Behaving milestone 2024-03-13 13:02:15 +00:00

john added this to the The Datatype Overhaul project 2024-03-13 13:06:39 +00:00

john commented

2024-04-20 17:43:01 +00:00

Should be a quick fix: all the ECS specific stuff has already been removed, so "sRender" is the only remaining vestige.

$ grep "sRender" *
GameEngine.cpp:        currentScene()->sRender();
PyScene.cpp:void PyScene::sRender()
PyScene.h:    void sRender() override final;
Scene.h:    virtual void sRender() = 0;
grep: scripts: Is a directory
UITestScene.cpp:void UITestScene::sRender()
UITestScene.h:    void sRender() override final;

Should be a quick fix: all the ECS specific stuff has already been removed, so "sRender" is the only remaining vestige. ``` $ grep "sRender" * GameEngine.cpp: currentScene()->sRender(); PyScene.cpp:void PyScene::sRender() PyScene.h: void sRender() override final; Scene.h: virtual void sRender() = 0; grep: scripts: Is a directory UITestScene.cpp:void UITestScene::sRender() UITestScene.h: void sRender() override final; ```

john referenced this issue from a commit

2024-04-20 18:16:56 +00:00

Refactor: remove "s" prefix from "sRender" method ( -> "render") Closes #44

john closed this issue

2024-04-20 18:16:56 +00:00

Sign in to join this conversation.