john
/
McRogueFace
1
0
Fork 0
Code Issues 46 Pull Requests Projects 1 Releases Wiki Activity

Standardize Font Handling #60

New Issue
Closed
opened 2024-03-09 20:54:16 +00:00 by john · 5 comments
john commented 2024-03-09 20:54:16 +00:00
Owner
Copy Link

43 feat: Caption font member, set outside of __init__, change font, etc. This is the "standardize font handling" feature, too. [depends on RAII]

See #4, #5 - not strict dependencies, but related work

43 feat: Caption font member, set outside of `__init__`, change font, etc. This is the "standardize font handling" feature, too. \[depends on RAII] See #4, #5 - not strict dependencies, but related work
john added the
Minor Feature
Alpha Release Requirement
 labels 2024-03-09 20:54:16 +00:00
john added this to the All Datatypes Behaving milestone 2024-03-13 13:00:13 +00:00
john added this to the The Datatype Overhaul project 2024-03-13 13:06:39 +00:00
john added a new dependency 2024-03-13 13:14:54 +00:00
#58 Caption `__init__` is not correctly setting colors
john removed a dependency 2024-03-13 13:15:45 +00:00
#58 Caption `__init__` is not correctly setting colors
john added a new dependency 2024-03-13 13:21:55 +00:00
#66 Standardize Audio Handling
john removed a dependency 2024-03-13 13:22:02 +00:00
#66 Standardize Audio Handling
john added a new dependency 2024-03-13 14:46:15 +00:00
#5 Provide default Font and Texture
john commented 2024-03-31 01:32:10 +00:00
Author
Owner
Copy Link

Goal: Speed. Copy PyTexture for the structure of this object.

Goal: **Speed**. Copy `PyTexture` for the structure of this object.
john commented 2024-04-01 01:44:26 +00:00
Author
Owner
Copy Link

159658521c

I was hoping for a quick win, but this will take a little bit longer to not introduce instability.

I've also got default items added to the module, but mcrfpy.default_font fails the type check within UICaption's init. When executing type(mcrfpy.default_font), I get a segfault. So I'm obviously missing some step somewhere either to make the types fully available to Python, or to assign the type to new objects that I'm building in C++ with GenericAlloc and friends.

159658521c64a0cee8dd97ae7a2872a4eea2d9fa I was hoping for a quick win, but this will take a little bit longer to not introduce instability. I've also got default items added to the module, but `mcrfpy.default_font` fails the type check within UICaption's init. When executing `type(mcrfpy.default_font)`, I get a segfault. So I'm obviously missing some step somewhere either to make the types fully available to Python, or to assign the type to new objects that I'm building in C++ with GenericAlloc and friends.
john added spent time 2024-04-01 01:44:39 +00:00
1 hour 10 minutes
john commented 2024-04-06 21:18:06 +00:00
Author
Owner
Copy Link

https://discuss.python.org/t/instantiating-python-objects-from-c-segfault-on-type-obj-class-attribute-missing/50432

I'm on the Python Discussion boards asking what I'm doing wrong.

https://discuss.python.org/t/instantiating-python-objects-from-c-segfault-on-type-obj-class-attribute-missing/50432 I'm on the Python Discussion boards asking what I'm doing wrong.
john commented 2024-04-07 19:25:07 +00:00
Author
Owner
Copy Link

commit: a19781b56a

notes on Python Discuss instance: https://discuss.python.org/t/instantiating-python-objects-from-c-segfault-on-type-obj-class-attribute-missing/50432/5

I used mcrfpy.default_texture / PyTextureType to determine the process.

  • fetch the fully initialized type from the post-initialization imported module with auto type = (PyTypeObject*)PyObject_GetAttrString(McRFPy_API::mcrf_module, "Texture"); (where the Python type attribute string is switched)
  • perform alloc / new steps on the custom type with tp_alloc or the C++ class's pynew static method.
  • sideload stuff into the struct as desired.
commit: a19781b56a87b68309e63c88e4eb68d22523267d notes on Python Discuss instance: https://discuss.python.org/t/instantiating-python-objects-from-c-segfault-on-type-obj-class-attribute-missing/50432/5 I used `mcrfpy.default_texture` / `PyTextureType` to determine the process. * fetch the **fully initialized** type from the **post-initialization imported module** with `auto type = (PyTypeObject*)PyObject_GetAttrString(McRFPy_API::mcrf_module, "Texture");` (where the Python type attribute string is switched) * perform alloc / new steps on the custom type with `tp_alloc` or the C++ class's `pynew` static method. * sideload stuff into the struct as desired.
john added spent time 2024-04-07 19:25:28 +00:00
2 hours
john deleted spent time 2024-04-07 19:25:39 +00:00
- 2 hours
john commented 2024-04-07 19:26:10 +00:00
Author
Owner
Copy Link

I'll add a separate issue to solve the type bug - that wasn't part of the Font feature.

I'll add a separate issue to solve the type bug - that wasn't part of the Font feature.
john closed this issue 2024-04-08 02:53:14 +00:00
john added spent time 2024-04-08 02:53:55 +00:00
1 hour 30 minutes
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
rogueliketutorial25
alpha_presentable
alpha_streamline_2
alpha_streamline_1
interpreter_mode
grid_entity_integration
reprs_and_member_names
break_up_ui_h
standardize_font_handling
standardize_vector_handling
standardize_color_handling
standardize_texture_handling
raii_pyobjects
rebase-for-7DRL_Feb-2024
engjam_uicollection
engjam_ui_overhaul
Labels
Clear labels   
Alpha Release Requirement

This issue is a blocker to 0.1 Alpha release of McRogueFace.

  
Bugfix

   
Demo Target

Functionality to demonstrate; Depends on new features, but this issue isn't for writing them.

  
Documentation

   
Major Feature

Significant time and effort required.

  
Minor Feature

Some effort required to create or overhaul functionality.

  
priority:tier1-active

Current development focus - critical path to v1.0

  
priority:tier2-foundation

Important foundation work - not blocking v1.0

  
priority:tier3-future

Future features - deferred until after v1.0

  
Refactoring & Cleanup

no new functionality, just improving the codebase.

  
system:animation

Animation and property interpolation

  
system:documentation

Documentation infrastructure

  
system:grid

Grid system and spatial containers

  
system:input

Input handling and events

  
system:performance

Performance optimization and profiling

  
system:python-binding

Python/C++ binding layer

  
system:rendering

Rendering pipeline and visuals

  
system:ui-hierarchy

UI component hierarchy and composition

  
Tiny Feature

quick and easy - a few lines or with little interconnection around the codebase

  
workflow:blocked

Blocked by other work - waiting on dependencies

  
workflow:needs-benchmark

Needs performance testing and benchmarks

  
workflow:needs-documentation

Needs documentation before or after implementation

No Label
Alpha Release Requirement
Bugfix
Demo Target
Documentation
Major Feature
Minor Feature
priority:tier1-active
priority:tier2-foundation
priority:tier3-future
Refactoring & Cleanup
system:animation
system:documentation
system:grid
system:input
system:performance
system:python-binding
system:rendering
system:ui-hierarchy
Tiny Feature
workflow:blocked
workflow:needs-benchmark
workflow:needs-documentation
Milestone
Clear milestone
No items
No Milestone
All Datatypes Behaving
Projects
Clear projects
No project
The Datatype Overhaul
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Total Time Spent: 2 hours 40 minutes
john
2 hours 40 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#5 Provide default Font and Texture
john/McRogueFace
Reference: john/McRogueFace#60
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?