Standardize Vector Handling #13

New Issue

john · 2024-03-09T18:34:17Z

john commented

2024-03-09 18:34:17 +00:00

notes say:
17 feat: standardize vector handling: 2-tuple or 2 member lists, any mix of ints or floats; or (new) Vector object [depend on SFML module feature]

This issue is for a single method to take a PyObject* of any of the above and return a mcrfpy.Vector2 (or sfml::Vector2f wrapper, if possible)

Once the method is available, every widget that uses vectors (Frame, Caption, Sprite, Grid) needs to use the standardized method.

notes say: 17 feat: standardize vector handling: 2-tuple or 2 member lists, any mix of ints or floats; or (new) Vector object \[depend on SFML module feature] This issue is for a single method to take a PyObject* of any of the above and return a mcrfpy.Vector2 (or sfml::Vector2f wrapper, if possible) Once the method is available, every widget that uses vectors (Frame, Caption, Sprite, Grid) needs to use the standardized method.

john added the

Alpha Release Requirement

Refactoring & Cleanup

Bugfix

Major Feature

labels 2024-03-09 18:34:17 +00:00

john referenced this issue

2024-03-09 19:41:50 +00:00

Break up `UI.h` into respective class files #43

john referenced this issue

2024-03-09 20:09:17 +00:00

Standardize Member Variable naming conventions #56

john referenced this issue

2024-03-09 21:18:05 +00:00

Standardize Audio Handling #66

john added this to the All Datatypes Behaving milestone 2024-03-13 12:59:20 +00:00

john added this to the The Datatype Overhaul project 2024-03-13 13:06:39 +00:00

john commented

2024-03-31 01:32:53 +00:00

Goal: Speed. Copy PyColor for the structure of this object.

Goal: **Speed**. Copy `PyColor` for the structure of this object.

john started working 2024-03-31 02:04:18 +00:00

john commented

2024-03-31 02:33:27 +00:00

1c12e8719c
Gotta go fast - got it to build, got an example position from a UIDrawable.

Can't figure out why my init func isn't working, which means the mcrfpy.Color init function is probably undertested.

1c12e8719c1ed8002c80ee744178f8278e2c7e8c Gotta go fast - got it to build, got an example position from a UIDrawable. Can't figure out why my init func isn't working, which means the mcrfpy.Color init function is probably undertested.

john stopped working 2024-03-31 02:33:30 +00:00

29 minutes 12 seconds

john commented

2024-03-31 21:59:02 +00:00

Coding sporadically over the morning & afternoon; made some commits before errands.

This issue will now be closed. Here's the salient portion:

    static PyObject* PyUICaption_get_vec_member(PyUICaptionObject* self, void* closure)
    {
        return PyVector(self->data->text.getPosition()).pyObject();
    }

    static int PyUICaption_set_vec_member(PyUICaptionObject* self, PyObject* value, void* closure)
    {
        self->data->text.setPosition(PyVector::fromPy(value));
        return 0;
    }

There is more work to do in the init methods of the UIDrawables, but the intention with the tuple versions of Vector and Color means that the argument should just be passed to PyVector's / PyColor's constructor. If it fails, then UIDrawable init should also fail.

That refactor belongs to the UI.h breakup story, #43.

Coding sporadically over the morning & afternoon; made some commits before errands. This issue will now be closed. Here's the salient portion: ```c++ static PyObject* PyUICaption_get_vec_member(PyUICaptionObject* self, void* closure) { return PyVector(self->data->text.getPosition()).pyObject(); } static int PyUICaption_set_vec_member(PyUICaptionObject* self, PyObject* value, void* closure) { self->data->text.setPosition(PyVector::fromPy(value)); return 0; } ``` There is more work to do in the init methods of the UIDrawables, but the intention with the tuple versions of Vector and Color means that the argument should just be passed to PyVector's / PyColor's constructor. If it fails, then UIDrawable init should also fail. That refactor belongs to the UI.h breakup story, #43.

john referenced this issue from a commit

2024-03-31 22:00:55 +00:00

Squashed commit of the following: [standardize_vector_handling]

john closed this issue

2024-03-31 22:00:55 +00:00

john added spent time 2024-03-31 22:01:06 +00:00

45 minutes

Sign in to join this conversation.