john
/
McRogueFace
1
0
Fork 0
Code Issues 47 Pull Requests Projects 1 Releases Wiki Activity

Standardize Member Variable naming conventions #56

New Issue
Closed
opened 2024-03-09 20:09:17 +00:00 by john · 2 comments
john commented 2024-03-09 20:09:17 +00:00
Owner
Copy Link

37 refactor: make sure all UIDrawables use consistent member names for fill_color, outline_color, position, size, etc; [depends on RAII] [depends on standardize vector handling] [depends on standardize color handling]

Depends on:

  • #11, #13, #18 (Standardize X data type)
  • #4 (RAII consistency)

While we're at it, make the C++ and Python variables identical, or formulaic. Python has some getset variables that are not actually in C++, but it should be clear what they derive from

37 refactor: make sure all UIDrawables use consistent member names for fill_color, outline_color, position, size, etc; \[depends on RAII] \[depends on standardize vector handling] \[depends on standardize color handling] Depends on: * #11, #13, #18 (Standardize X data type) * #4 (RAII consistency) While we're at it, make the C++ and Python variables identical, or formulaic. Python has some `getset` variables that are not actually in C++, but it should be clear what they derive from
john added the
Alpha Release Requirement
Minor Feature
Refactoring & Cleanup
 labels 2024-03-09 20:09:17 +00:00
john added this to the All Datatypes Behaving milestone 2024-03-13 14:11:54 +00:00
john added this to the Fun, Convenient McRogueFace Objects project 2024-03-13 14:37:15 +00:00
john commented 2024-04-11 03:22:52 +00:00
Author
Owner
Copy Link

#18 (comment)

Time to pay the piper...

https://gamedev.ffwf.net/gitea/john/McRogueFace/issues/18#issuecomment-354 Time to pay the piper...
john added a new dependency 2024-04-11 03:24:51 +00:00
#31 `__repr__` displays match the getsetter member names
john commented 2024-04-20 22:35:33 +00:00
Author
Owner
Copy Link

Must have caught this stuff elsewhere: there was no inconsistency left when I went to work on it.

Must have caught this stuff elsewhere: there was no inconsistency left when I went to work on it.
john closed this issue 2024-04-20 22:35:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
rogueliketutorial25
alpha_presentable
alpha_streamline_2
alpha_streamline_1
interpreter_mode
grid_entity_integration
reprs_and_member_names
break_up_ui_h
standardize_font_handling
standardize_vector_handling
standardize_color_handling
standardize_texture_handling
raii_pyobjects
rebase-for-7DRL_Feb-2024
engjam_uicollection
engjam_ui_overhaul
Labels
Clear labels   
Alpha Release Requirement

This issue is a blocker to 0.1 Alpha release of McRogueFace.

  
Bugfix

   
Demo Target

Functionality to demonstrate; Depends on new features, but this issue isn't for writing them.

  
Documentation

   
Major Feature

Significant time and effort required.

  
Minor Feature

Some effort required to create or overhaul functionality.

  
priority:tier1-active

Current development focus - critical path to v1.0

  
priority:tier2-foundation

Important foundation work - not blocking v1.0

  
priority:tier3-future

Future features - deferred until after v1.0

  
Refactoring & Cleanup

no new functionality, just improving the codebase.

  
system:animation

Animation and property interpolation

  
system:documentation

Documentation infrastructure

  
system:grid

Grid system and spatial containers

  
system:input

Input handling and events

  
system:performance

Performance optimization and profiling

  
system:python-binding

Python/C++ binding layer

  
system:rendering

Rendering pipeline and visuals

  
system:ui-hierarchy

UI component hierarchy and composition

  
Tiny Feature

quick and easy - a few lines or with little interconnection around the codebase

  
workflow:blocked

Blocked by other work - waiting on dependencies

  
workflow:needs-benchmark

Needs performance testing and benchmarks

  
workflow:needs-documentation

Needs documentation before or after implementation

No Label
Alpha Release Requirement
Bugfix
Demo Target
Documentation
Major Feature
Minor Feature
priority:tier1-active
priority:tier2-foundation
priority:tier3-future
Refactoring & Cleanup
system:animation
system:documentation
system:grid
system:input
system:performance
system:python-binding
system:rendering
system:ui-hierarchy
Tiny Feature
workflow:blocked
workflow:needs-benchmark
workflow:needs-documentation
Milestone
Clear milestone
No items
No Milestone
All Datatypes Behaving
Projects
Clear projects
No project
Fun, Convenient McRogueFace Objects
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#31 `__repr__` displays match the getsetter member names
john/McRogueFace
Reference: john/McRogueFace#56
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?