John McCardle

john commented on issue john/McRogueFace#56

2024-04-20 22:35:33 +00:00

Standardize Member Variable naming conventions

Must have caught this stuff elsewhere: there was no inconsistency left when I went to work on it.

john pushed to master at john/McRogueFace

2024-04-20 22:34:07 +00:00

232105a893 Squashed commit of the following: [reprs_and_member_names]

john closed issue john/McRogueFace#25

2024-04-20 22:34:07 +00:00

UIGridPointState __repr__

john closed issue john/McRogueFace#24

2024-04-20 22:34:07 +00:00

UIGridPoint __repr__

john closed issue john/McRogueFace#23

2024-04-20 22:34:07 +00:00

UIEntity __repr__

john closed issue john/McRogueFace#22

2024-04-20 22:34:07 +00:00

UIGrid __repr__

john created branch reprs_and_member_names in john/McRogueFace

2024-04-20 22:33:04 +00:00

john pushed to reprs_and_member_names at john/McRogueFace

2024-04-20 22:33:04 +00:00

43fac8f4f3 Typo in UIFrame repr

3fd5ad93e2 Add UIGridPoint and UIGridPointState repr

03376897b8 Add UIGrid repr

48af072a33 Add UIEntity repr

Compare 4 commits »

john closed issue john/McRogueFace#29

2024-04-20 18:23:16 +00:00

implement __hash__ in a way that preserves C++ object identity

john commented on issue john/McRogueFace#29

2024-04-20 18:23:16 +00:00

implement __hash__ in a way that preserves C++ object identity

wontfix / the current usage of hash is probably incorrect and should be deprecated. Hashable object should be immutable. So the mcrf data containers probably should not have this value.

john commented on issue john/McRogueFace#57

2024-04-20 18:19:59 +00:00

Sprites not responding to mouse events

can't replicate - maybe refactors accidentally fixed this?

john closed issue john/McRogueFace#57

2024-04-20 18:19:59 +00:00

Sprites not responding to mouse events

john pushed to master at john/McRogueFace

2024-04-20 18:16:56 +00:00

c2de9b08d6 Refactor: remove "s" prefix from "sRender" method ( -> "render") Closes #44

john closed issue john/McRogueFace#44

2024-04-20 18:16:56 +00:00

clean up COMP4300 style

john commented on issue john/McRogueFace#44

2024-04-20 17:43:01 +00:00

clean up COMP4300 style

Should be a quick fix: all the ECS specific stuff has already been removed, so "sRender" is the only remaining vestige.

$ grep "sRender" *
GameEngine.cpp:        currentScene()->sRender();…

john pushed to master at john/McRogueFace

2024-04-20 17:37:46 +00:00

a465a9861d Color parsing for UICaption __init__ - closes #58

john closed issue john/McRogueFace#58

2024-04-20 17:37:46 +00:00

Caption __init__ is not correctly setting colors

john closed issue john/McRogueFace#43

2024-04-20 14:34:10 +00:00

Break up UI.h into respective class files

john pushed to master at john/McRogueFace

2024-04-20 14:33:21 +00:00

ac7f7052cd Squashed commit of the following: [break_up_ui_h]

john commented on issue john/McRogueFace#43

2024-04-20 01:45:56 +00:00

Break up UI.h into respective class files

Ready to merge (?)

cos_play has segfaults, which I may want to fix before wrapping this issue... I am rushing to meet the April…